edge-react-gui icon indicating copy to clipboard operation
edge-react-gui copied to clipboard

Published 20 hours ago • verified publisher icon EdgeApp

Update ListModal props

Open Jon-edge opened this issue 2 years ago • 1 comments
trafficstars

Copied from loginUI changes.

Make it more specific to the functionality - hideSearch. Remove the need to specify a value when setting hideSearch.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • [x] Yes
  • [ ] No

Dependencies

https://github.com/EdgeApp/edge-login-ui-rn/pull/139

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • [ ] Tested on iOS device
  • [x] Tested on Android device
  • [ ] Tested on small-screen device (iPod Touch)
  • [ ] Tested on large-screen device (tablet)
  • To see the specific tasks where the Asana app for GitHub is being used, see below:
    • https://app.asana.com/0/0/1205825049877477

Jon-edge avatar Oct 28 '23 00:10 Jon-edge

As mentioned in the other PR review, we might not need these changes after all, since we want to decouple the login-ui and GUI versions of these components.

swansontec avatar Oct 30 '23 18:10 swansontec