EddieHubCommunity
Feat: Search Bar Story added
Fixes Issue
Closes #1989
Changes proposed
- [x] Refactored Search Component into a separate file for reuse in story
- [x] Changed the placeholder in Search Bar for better grammar
- [x] Added the Search Bar Story
Check List (Check all the applicable boxes)
- [x] My code follows the code style of this project.
- [ ] My change requires changes to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] All new and existing tests passed.
- [x] This PR does not contain plagiarized content.
- [x] The title of my pull request is a short description of the requested changes.
Screenshots
Welcome @ThePiyushAggarwal! Thank you so much for your first pull request!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @ThePiyushAggarwal! Thank you so much for your first pull request!
I am not able to remove some files from commit. 3 files with .json have gotten inside the PR when I did a merge commit for main into my branch. I think the pre-commit hooks are running lint commands and making those changes. As when I tried to manually remove the unnecessary changes, it said commit stopped since it is empty.
I can help you with this.
-
Go to you fork on github main branch. click the
sync forkbutton.
-
Go to you local repo. use
git checkout mainto navigate to main branch. -
git fetch upstream -
git merge upstream/main -
git checkout feature-ThePiyushAggarwal-1989-search-story -
use these commands to revert the files
git checkout main -- data/AdamsGeeky.jsongit checkout main -- data/SubhadeepZilong.jsongit checkout main -- data/ndzhwr.json
-
git add .(Make sure you don't have any other changes) -
git commit -m "any message" -n(-n will skip the linter) -
git push origin feature-ThePiyushAggarwal-1989-search-storypush the changes
Thanks a lot @ChinmayMhatre !
The unnecessary files are not showing up in the PR now.
I realized there were some errors in the browser console in storybook.
Fixed them as well
I deleted my fork and this got closed. Anyway, I don't think anyone cares about this PR. Thanks!
I deleted my fork and this got closed. Anyway, I don't think anyone cares about this PR. Thanks!
Hey @ThePiyushAggarwal , I understand the frustration of getting an error. Sometimes PR's and issues get delayed for multiple reasons.
You see some PR's getting merged quickly as they are simple profile additions and can be reviewed by all the maintainers. Some larger PR are reviewed by specific maintainers and can take some time to be reviewed. All the maintainers have to take time from their work, life etc to review so it does take of time .
In case the PR's hasn't been reviewed for a week or more which this one is. I would suggest pinging Eddie once, if that is missed you can go to the discord server and put your issue in the contributor support channel. Hope you understand.
@ThePiyushAggarwal your PR was great, sorry for being slow in responding, but I get many notifications. Also your PR has chore: profile addition because it has profile changes in it, which I leave these PRs for other maintainers and they probably left it for me because it had other code changes - this is why it is so important to keep PRs focused on a single improvement/change.
Yes deleting your fork will close the PR, but you can still get your code changes from the PR if you wish to create a new PR and we can get it merged
Storybook and Playwright automated tests are super important 👍 so I would love this PR if you are happy to open another PR, sorry again for the delay
Thanks for responding!
I think the chore: profile addition lable got added when the linter made some changes in the .json files but after that I reverted those.
I am reopening this PR. This PR contains changes for only the storybook for SearchInput component.