BioDrop icon indicating copy to clipboard operation
BioDrop copied to clipboard

[OTHER] Improvement: Increase discoverability of clickable QR code

Open amandamartin-dev opened this issue 3 years ago • 8 comments

What would you like to share?

The animated QR code on the user image is clickable, but this is not obvious. It would increase the UX of the site to make it easier to know that this is a link

Image shows the location of the QR code at the bottom left of the user profile image screenshot of linkfree page with a red arrow pointing to the qr code location

Additional information

No response

amandamartin-dev avatar Nov 20 '22 16:11 amandamartin-dev

It's great having you contribute to this project

Welcome to the community :nerd_face:

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

github-actions[bot] avatar Nov 20 '22 16:11 github-actions[bot]

Hi can I work on this issue?

DeeptanshuDas avatar Nov 22 '22 15:11 DeeptanshuDas

@DeeptanshuDas Sorry for the delay in responding, I missed your comment. I am fine with you taking this issue if you are still looking to work on it, but I do not have permissions to assign.

amandamartin-dev avatar Dec 04 '22 14:12 amandamartin-dev

@amandamartin-dev It seems this issue is still open and @DeeptanshuDas hasn't replied. I would like to work on this issue.

SuperGrut avatar Jan 02 '23 13:01 SuperGrut

Sure I have assigned it to you @akash19coder as I think they are no longer interested

eddiejaoude avatar Jan 02 '23 13:01 eddiejaoude

@eddiejaoude I have forked and cloned the repo but I am not sure where to start from?

SuperGrut avatar Jan 02 '23 14:01 SuperGrut

@akash19coder what ideas do you have? maybe making it larger?

eddiejaoude avatar Jan 09 '23 11:01 eddiejaoude

@eddiejaoude How about making a little shift? 😄 Eddie Jaoude

SuperGrut avatar Jan 10 '23 03:01 SuperGrut

I think that is too confusing, this section is for social icons, keeping it separate would be better

eddiejaoude avatar Jan 11 '23 20:01 eddiejaoude

Hey @eddiejaoude can i work on this feature. i would suggest that we can add some box shadow so that it catches users attention and also we can make it a little bit bigger.

arun-kushwaha04 avatar Jan 22 '23 20:01 arun-kushwaha04

Hey @arun-kushwaha04 , I see that @akash19coder is currently assigned to this issue. Let's see if they are still interested and working on it first. You both can also collaborate if you like!

amandamartin-dev avatar Jan 23 '23 13:01 amandamartin-dev

@eddiejaoude I have increased the size and changed its color into red 😃

SuperGrut avatar Jan 23 '23 14:01 SuperGrut

I have unassigned this as there has been no activity for two weeks.

We suggest making the icon size bigger and possibly having a faded background.

SaraJaoude avatar Feb 03 '23 14:02 SaraJaoude

Hello!

Can someone please assign this issue to me?

I have already experimented with it. I haven't increased the size of the component. I have just given it a faded background. I feel the size is alright. Please let me know if you think we should increase it. The image below is captured after zooming into the browser.

I am also thinking of making this into a separate QRToggler component. Should I go ahead with that as well in the same PR?

image

ThePiyushAggarwal avatar Feb 12 '23 13:02 ThePiyushAggarwal

Would it not make sense to just have it on the dashboard 🤔 Why would someone else need to have a QR code to my profile. Just my opinion though.

Also @ThePiyushAggarwal we only assign contributors to 1 issue at a time afaik

gptkrsh avatar Feb 12 '23 14:02 gptkrsh

Eddie worked on this issue himself today. PR #4479 image

ThePiyushAggarwal avatar Feb 12 '23 16:02 ThePiyushAggarwal

I moved all badges to a single reusable component. There might be further improvements to the QR code badge?

eddiejaoude avatar Feb 12 '23 16:02 eddiejaoude

I moved all badges to a single reusable component. There might be further improvements to the QR code badge?

I think it's much more visible now with the orange background but not sure how others feel

amandamartin-dev avatar Feb 12 '23 19:02 amandamartin-dev

Maybe let's close it for now and the issue could be created again if required

@ThePiyushAggarwal thank you for contributing, have a look at our other issues that have the label ready for dev and are not assigned yet

eddiejaoude avatar Feb 13 '23 02:02 eddiejaoude