free-programming-books icon indicating copy to clipboard operation
free-programming-books copied to clipboard

Missing resource in Hebrew book list

Open JenIsCoding opened this issue 2 years ago • 3 comments

What does this PR do?

This PR fix the issue Bad url Java heb book #9338; the missing resource (The Israeli Guide to Java) was deleted.

Checklist:

  • [x] Read our contributing guidelines.
  • [ ] Search for duplicates.
  • [ ] Include author(s) and platform where appropriate.
  • [x] Put lists in alphabetical order, correct spacing.
  • [ ] Add needed indications (PDF, access notes, under construction).
  • [x] Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

JenIsCoding avatar Jun 16 '23 22:06 JenIsCoding

It says:

1217:3-1217:201 warning Misplaced author books-links remark-lint

I checked the alignment and it seems ok to me. 😭 Can someone tell me where the error is? Thank you 😊

Edit: Sorry, I made a stupid mistake 😞, now it seems to work!

JenIsCoding avatar Jun 16 '23 23:06 JenIsCoding

2 things:

  1. need to also remove Java from the index
  2. Usually better to use separate branches for each change- your commit for the OSINT book is now included in this PR. It's OK, but it was confusing to review.

eshellman avatar Jun 20 '23 08:06 eshellman

  1. Usually better to use separate branches for each change

You're right. Next time, I will create a new branch for each issue.

your commit for the OSINT book is now included in this PR.

Thank you.

JenIsCoding avatar Jun 20 '23 17:06 JenIsCoding

hi

kypena avatar Jul 25 '23 22:07 kypena

Oh no 😟! Conflicts have been found.

Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again.

Thanks in advance for your effort and patience ❤️!

github-actions[bot] avatar Jul 27 '23 14:07 github-actions[bot]

This Pull Request has been automatically marked as stale because it has not had recent activity during last 60 days :sleeping:

It will be closed in 30 days if no further activity occurs. To unstale this PR, draft it, remove stale label, comment with a detailed explanation or push more commits.

There can be many reasons why some specific PR has no activity. The most probable cause is lack of time, not lack of interest.

Thank you for your patience :heart:

github-actions[bot] avatar Sep 27 '23 00:09 github-actions[bot]

no changes left

eshellman avatar Nov 07 '23 01:11 eshellman