Joseph Burton

Results 298 comments of Joseph Burton
trafficstars

Sorry, but this PR does not reflect the changes your are testing then. Click "changed files" at the top.

You are being quite uncooperative. Please listen to what I'm trying to say or I will unfortunately have to reject this PR.

What you need to do is modify more code to throw a ThrowableSuppression rather than removing the purpose of ThrowableSuppression.

You are getting closer to a good solution, however you still haven't taken into account part of my first message: > it would be better to go through the tick...

My goodness that's a lot of code! Before I start reviewing it properly, can you reindent your added files with 4 spaces rather than tabs?

Yeah it should, commands is only for the interface with the user

Is there a way to generate some of the documentation from Javadocs using readthedocs?

You were using an ancient version of clientcommands with a newer Minecraft version

You have to do that yourself by doing one of the forbidden actions, most effective is relogging. The mod will automatically detect this.