Villager RNG Manipulation

[RealRTTV]

trafficstars

Add Villager RNG Manipulation to brute-force optimal trades

[xpple]

Holy fuck nice!

[erxson]

yooooo

[vanvac]

wait this is huge if this works

[RealRTTV]

it does, but im waiting on earth to do some final touches

[vanvac]

that will be sooo useful this is probably the best mod ive used

[vanvac]

XD i am seeing the build in progress live

[vanvac]

👍

[vanvac]

can i test out build artifacts? if so how?

[Earthcomputer]

can i test out build artifacts? if so how?

Yeah you just unzip it, get the mod jar out of it and then install it like a regular mod. It's in a working state but I won't be providing support for using it. It needs to be made more user friendly before it can be merged.

[vanvac]

the only zip file i could find in the artifacts was for im guessing what are the unit tests (cheked the zip files and all there is are the html pages)

[Earthcomputer]

Ah sorry, I forgot artifacts are not built for PRs. You will have to clone the PR and build it yourself. But again, this channel is for development, it's best to join the discord and ask in support if you get stuck.

[vanvac]

any updates/problems or just waiting for soemthing to do with mc versions

[RealRTTV]

currently we need to fix levelUp changes, but other than that it should be good

[vanvac]

hope this comes soon bc making villiager trading halls with this will be so much easier

[vanvac]

Idk if this is a knows issue or not but if a viliager loses its profession while its running the rng manipulation after running /cvilliager start the villiager cracking just dies and prevents the command from being run again, it is fixed by reloging and prob many more

[RealRTTV]

does /cvillager reset fix it?

[vanvac]

tried to recreat it and turns out my description isnt the best also /cvilliager reset isn't an available command

reproduce problem:

1. setup villiager cracking setup with a cracked villiager and a goal that would take a decent amount of time to find
2. break the profession block when the bar at the bottom is flling and the cracking is doing its thing
3. once the cracking completes it trys to open the villiager gui but cant as it is unemployed
4. then giving the villiager a proffession and trying to crack it would fail

fixes:

• relog
• interact with the villiager and reset the proffesion so you can crack trades again

half fix: these things allow the villiager rng to be cracked again but do not fix the soft lock

• anything that resets the villiager manipulation atumatically (eg. holding item in hand, villiager hurt, bad setup, etc)

ps. are there any plans to make it where you can specify like a below certian amount of emrald requirement eg. sharp 5 book for <=24 emralds

[Amirhan-Taipovjan-Greatest-I]

Hello! I'm sorry for non-Development related Question, but I really want to ask this so much: Is this "RNG Manipulation" will allow to manipulate Armorer's/Smiths' last (Master-Expert) Trades like Diamond Stuff?

[vanvac]

https://github.com/Earthcomputer/clientcommands/pull/642#issuecomment-2558501481 yes it will but im pretty sure that the feature to manupilate the traded for upgraded villiagers is broken as of now

[GodGun968]

I'm very interested in this so when will this be merged

[RealRTTV]

I was working on it a while ago, the last thing I was doing iirc was making nextLevel work correctly, I can maybe boot 'er up and see if I can patch it, I know someone made a diff to update to 1.21.9 or smth too.

[GodGun968]

Alright, keep it up. I'll provide the Chinese translation once you've finished and merged it.