clientcommands icon indicating copy to clipboard operation
clientcommands copied to clipboard

Published 20 hours ago • verified publisher icon Earthcomputer

Fix Command Redirects to avoid duplication of optional parameters

Open Domkeykong opened this issue 4 years ago • 3 comments
trafficstars

This fixes #164

Domkeykong avatar Mar 21 '21 15:03 Domkeykong

Currently there isn't really a method of providing default arguments! This was already discussed by you @Earthcomputer in Mojang/brigadier#18 / Mojang/brigadier#19 and an implementation by @NeunEinser Mojang/brigadier#42 remains to be merged

Domkeykong avatar Mar 21 '21 19:03 Domkeykong

I still think changing the suggestor is the best solution, but I'll keep this PR open in case I change my mind. (You missed a couple of withFlags btw, the best way to find them is to delete the withFlags and getFlags methods entirely and see if the project compiles).

Earthcomputer avatar Mar 21 '21 21:03 Earthcomputer

Have you pulled recently? There is also one in /ccalc that was added a couple of days ago.

Earthcomputer avatar Mar 22 '21 18:03 Earthcomputer