EnchantmentCracker icon indicating copy to clipboard operation
EnchantmentCracker copied to clipboard

Enchantment Level Predictions, for simpler verification of XP seed cracking. (Feature request)

Open HaphLife opened this issue 4 years ago • 14 comments
trafficstars

There are lots of ways that the user can mess up using this tool, and here's a few suggestions of changes that would allow the user to fix those errors, or never make them in the first place:

A: Enchantment level requirement predictions: Once you complete cracking an XP seed, the tool should predict all of the remaining enchantment level requirements, so that if the user cares to they can check if those are correct and become more certain that the XP seed is correctly cracked. Additionally, while doing dummy and wanted enchantments, it should continue to predict the enchantment level requirements, so that the user can tell they messed up before enchanting a wanted item (which currently wastes levels, lapis, and even the item pre-grindstone).

HaphLife avatar Jan 24 '21 22:01 HaphLife

How do I add labels?

HaphLife avatar Jan 24 '21 23:01 HaphLife

You can't, I have to do it. Please can you split your suggestions into separate issues? It makes it easier for me to track them individually.

Earthcomputer avatar Jan 24 '21 23:01 Earthcomputer

Okay. How granular do you want it. Is A-E good enough or should I split them up more?

HaphLife avatar Jan 24 '21 23:01 HaphLife

A-E is probably good enough

Earthcomputer avatar Jan 24 '21 23:01 Earthcomputer

Ok. On it.

HaphLife avatar Jan 24 '21 23:01 HaphLife

Could you re-open this, I editted it down to 1 suggestion. I could make a new version of this, but then the letters would be out of order. I guess that would let me fix the name.

HaphLife avatar Jan 24 '21 23:01 HaphLife

Ooh, I can edit the name. yay!

HaphLife avatar Jan 25 '21 00:01 HaphLife

Thank you :)

HaphLife avatar Jan 25 '21 00:01 HaphLife

The levels on the right will be the same as the input after you crack it, since there is no dummy enchantment that inherently comes after the cracking process. However it would be a good idea to display the XP levels before each actual enchantment, it would add a good way to verify before actually enchanting the item, which is particularly important pre-grindstone.

Earthcomputer avatar Jan 25 '21 00:01 Earthcomputer

I was meaning for the other shelf options. If I input shelves 15-10 to crack xp seed, and it then predicts shelves 9-0, I can check some of the remaining ones to verify it was the correct xp seed, and I didn’t get unlucky and make an incorrect input that was actually possible with a different seed.

HaphLife avatar Jan 25 '21 00:01 HaphLife

If you input incorrect data, it is much more likely to fail with 0 seeds remaining rather than find an incorrect seed. In this case, you can simply reset the cracker and crack the XP seed again (without losing progress). Doing better than this is covered by #245.

Earthcomputer avatar Jan 25 '21 00:01 Earthcomputer

Fair enough. As I mentioned in #245 it would be good to put these predictions in the same spot as over there, so that it doesn’t take up any extra UI space. The difference between the main point of this and the main point of #245 is that when you use the list in #245 you know you did something wrong, the xp seed cracking failed, but this is to reduce risk of false positives. I guess you’ll find out there was a false positive when you try to crack the player seed, but this lets you know which xp seed was wrong, and if it’s the first seed, lets you know while you can fix it.

HaphLife avatar Jan 25 '21 00:01 HaphLife

I don’t know how common the xp-seed false positive is, but it certainly is an edge-case.

HaphLife avatar Jan 25 '21 00:01 HaphLife

Failing to crack the player seed is usually due to doing banned actions in between the two XP seeds, playing on a paper server, or doing the steps in the wrong order. It's usually not a problem with either XP seed themselves.

Earthcomputer avatar Jan 25 '21 00:01 Earthcomputer