EnchantmentCracker icon indicating copy to clipboard operation
EnchantmentCracker copied to clipboard

Some characters don't display on some systems

Open Cccc-owo opened this issue 5 years ago • 20 comments
trafficstars

image image image In some places, it doesn't display text properly.Just like the pictures

Cccc-owo avatar Apr 01 '20 13:04 Cccc-owo

It looks like your font, but I will try and mitigate the problem before the 1.16 release

Earthcomputer avatar Apr 04 '20 12:04 Earthcomputer

see if you can change the font to Microsoft YaHei UI 把字体换成微软雅黑兼容性可能会好一点

Stehsaer avatar Apr 07 '20 04:04 Stehsaer

It's Java's responsibility to pick the correct font. I am currently asking for a sans serif font if the Minecraft font cannot display all the characters in a text. Perhaps I should ask for the font which Java normally uses for dialogs.

Earthcomputer avatar Apr 09 '20 09:04 Earthcomputer

@Cccc-u can you try building from the latest commit and see if the issue persists?

Earthcomputer avatar Apr 09 '20 09:04 Earthcomputer

Or @Stehsaer you could try as well?

Earthcomputer avatar Apr 10 '20 13:04 Earthcomputer

@Earthcomputer hi,i remade a language file. i tested it and it works fine on my PC.is it OK? EnchantmentCracker_zh.zip

Cccc-owo avatar Apr 13 '20 13:04 Cccc-owo

Is it possible to duplicate the whole project to C#(.net) that may help because it may be easier to deal with problems like this (creating a window that looks like a current one may be alittle harder... @Earthcomputer

Stehsaer avatar Apr 16 '20 02:04 Stehsaer

@Stehsaer of course, you can do that any time (i'm not going to myself though). If anyone wants to find a fix to the issue where the UTF-8 file actually loads properly on Windows (it seems to be a combination of the operating system or maybe Java version and the font), I would be very grateful.

Earthcomputer avatar Apr 16 '20 11:04 Earthcomputer

@Earthcomputer To be honest I don't know java much and i have no way to figure out how the cracker work. Can you provide how this thing works exactly and maybe i can make it in C#. thanks

Stehsaer avatar Apr 16 '20 15:04 Stehsaer

I explained how it works in the last 5 minutes of the video linked in the readme. You may need to read the enchantment cracker code or Minecraft code to get every detail. Also @Hexicube said something about making a .NET version, you should talk to him about it.

Earthcomputer avatar Apr 16 '20 15:04 Earthcomputer

I think I have managed to fix this issue by converting to the escape sequence format dynamically as the translations are loaded. This means we should get the best of both worlds, easy files for translators to edit, and support on more Java versions and systems, at the cost of just a few lines of slightly disgusting code. I'll create a release tomorrow with the 1.16 release, let me know whether this problem still persists.

Earthcomputer avatar Jun 22 '20 12:06 Earthcomputer

Does this issue still persist with the latest release, 1.5? @Cccc-owo

Earthcomputer avatar Jun 23 '20 14:06 Earthcomputer

@Earthcomputer
Oh,i am a little sorry. it works fine when it loading my language file. XD

Cccc-owo avatar Jun 24 '20 06:06 Cccc-owo

This is really weird. It should now be dynamically loading the same language file which you claim to work on your PC.

Earthcomputer avatar Jun 24 '20 09:06 Earthcomputer

@Cccc-owo but I don't want your language file, because raw unicode escape sequences are hard for translators to edit. I want a solution where my language file can be loaded. Can you tell me what is your Java version, operating system and maybe your log file too?

Earthcomputer avatar Jun 24 '20 15:06 Earthcomputer

@Cccc-owo but I don't want your language file, because raw unicode escape sequences are hard for translators to edit. I want a solution where my language file can be loaded. Can you tell me what is your Java version, operating system and maybe your log file too?

Well,i understand. i'm using Java 14.0.1 and Windows 10 1909. This is my log File in \bin enchcracker.log

Cccc-owo avatar Jun 24 '20 15:06 Cccc-owo

Sorry, what is your log file?

Earthcomputer avatar Jun 24 '20 16:06 Earthcomputer

This just happened to someone with the Ł character in the Polish language

Earthcomputer avatar Jul 19 '20 12:07 Earthcomputer

No, just because you have fixed it for yourself doesn't mean that the problem has gone away.

Earthcomputer avatar Jul 25 '20 08:07 Earthcomputer

Shouldn't you try using a noto font? maybe one of the CJK ones

ImUrX avatar Sep 30 '20 21:09 ImUrX