CDEPS icon indicating copy to clipboard operation
CDEPS copied to clipboard

Fix and improve anomaly forcings for ISSP cases

Open samsrabin opened this issue 1 year ago • 5 comments
trafficstars

Description of changes

Fixes a bug, and also makes it much simpler to run land-only SSP cases.

Specific notes

Contributors other than yourself, if any: @ekluzek

CDEPS Issues Fixed (include github issue #):

  • Resolves #186
  • Fixes #258
  • Resolves #310

Are there dependencies on other component PRs (if so list): This doesn't depend on other components. However, I will soon submit a PR to CTSM that depends on this branch. (See issue ESCOMP/CTSM#2301.)

Are changes expected to change answers (bfb, different to roundoff, more substantial): Substantial, but only if people were being bitten by #258 before.

Any User Interface Changes (namelist or namelist defaults changes): Yes.

Adds anomaly_forcing options:

  • Anomaly.Forcing.cmip5.rcp45
  • Anomaly.Forcing.cmip6.ssp126
  • Anomaly.Forcing.cmip6.ssp245
  • Anomaly.Forcing.cmip6.ssp370
  • Anomaly.Forcing.cmip6.ssp585

Removes all variable-specific anomaly_forcing options.

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

  • New CTSM testmods using these work correctly. Existing testmod, datm_ssp126_anom_forc, is bit-for-bit identical to previous version (ctsm5.2.015).
  • On top of existing aux_cdeps test of SSP585 compset, added the 3 other SSP compsets. All aux_cdeps SSP tests show diffs as expected from cdeps1.0.34.

Hashes used for testing:

  • Various throughout process.

Remaining work

  • [x] Make it so that anomaly_forcing is automatically set for each ISSP compset
  • [ ] (Done but I need a non-I SSP compset to test) Ensure that it's only set for DATM compsets
  • [x] If we care that it's not putting anomaly_forcing in the generated datm_in: Fix that. (Note that the anomaly forcing file IS correctly being put in datm.streams.xml.)

samsrabin avatar Aug 09 '24 03:08 samsrabin

@ekluzek, a few questions:

  • What sort of changes/additions would you like me to make to aux_cdeps?
  • Does it make sense to keep the Anomaly.Forcing.Precip, Anomaly.Forcing.Temperature, etc. entries in stream_definition_datm.xml? If so, I'll need to rename them so they're specific to rcp45, then add equivalent ones for each SSP. Seems messy!
  • To make the ISSP compsets automatically use the right anomaly_forcing, would I do something like this in namelist_definition_datm.xml under <entry id="anomaly_forcing">?
<default_value>''</default_value>
<value compset="^SSP126_">Anomaly.Forcing.cmip6.ssp126</value>

samsrabin avatar Aug 09 '24 03:08 samsrabin

@samsrabin is this ready- if not can you make it a draft please.

jedwards4b avatar Aug 22 '24 13:08 jedwards4b

Force-pushed to remove premature merge of main into this branch, which was interfering with my testing.

samsrabin avatar Sep 05 '24 20:09 samsrabin

@ekluzek This is ready, if you'd like to review!

samsrabin avatar Sep 06 '24 17:09 samsrabin

Note that this is up-to-date with cdeps1.0.34. If you'd like me to merge in the latest tag, let me know and I'll redo the testing.

samsrabin avatar Sep 06 '24 17:09 samsrabin

@jedwards4b This is ready to review, and @ekluzek will also make some time to look at it in the next few days. It would be nice if we can get it in soon.

samsrabin avatar Nov 04 '24 17:11 samsrabin

Re-requesting review from @ekluzek, because it seems like I've already addressed his concern. If approved, I'll continue by merging in the latest CTSM tag into ESCOMP/CTSM#2686 and the corresponding CDEPS tag here.

samsrabin avatar Feb 19 '25 22:02 samsrabin

Re-pinging @ekluzek for review, since @jedwards4b seems to think things are fine as is.

samsrabin avatar Mar 11 '25 15:03 samsrabin

@jedwards4b I think this is ready!

samsrabin avatar Mar 19 '25 17:03 samsrabin

@samsrabin can you merge main into your branch or give me permission to push to your fork?

jedwards4b avatar Mar 19 '25 18:03 jedwards4b

@jedwards4b Done!

samsrabin avatar Mar 19 '25 18:03 samsrabin