e2openplugin-OpenWebif icon indicating copy to clipboard operation
e2openplugin-OpenWebif copied to clipboard

Transcoding port

Open adoxa opened this issue 4 years ago • 3 comments

For transcoding OWIF reads the port from config.plugins.transcodingsetup.port.value, but that is not defined in MultiTransCodingSetup, so fails and uses None. Another test should be used to detect transcoding support (or just use 8001, since the port can't be changed, anyway).

adoxa avatar Dec 07 '20 12:12 adoxa

On a related note, TranscodingController is also testing for config.plugins.transcodingsetup.port and thus failing.

adoxa avatar Dec 08 '20 00:12 adoxa

Possibly related to #1208

/openwebif/plugin/controllers/ajax.py up to this week used the code below...

the getMachineBuild() line was last updated 3 years ago which means it's well-overdue an update (preferably by using feature-detection instead of device name checking).

	def P_webtv(self, request):
		if config.OpenWebif.auth_for_streaming.value:
			session = GetSession()
			if session.GetAuth(request) is not None:
				auth = ':'.join(session.GetAuth(request)) + "@"
			else:
				auth = '-sid:' + str(session.GetSID(request)) + "@"
		else:
			auth = ''
		vxgenabled = False
		if fileExists(getPublicPath("/vxg/media_player.pexe")):
			vxgenabled = True
		transcoding = TRANSCODING
		transcoder_port = 0
		if transcoding:
			try:
				transcoder_port = int(config.plugins.transcodingsetup.port.value)
				if getMachineBuild() in ('inihdp', 'hd2400', 'et10000', 'et13000', 'sf5008', 'ew7356', 'formuler1tc', 'tiviaraplus', '8100s'):
					transcoder_port = int(config.OpenWebif.streamport.value)
			except Exception:
				transcoder_port = 0
		return {"transcoder_port": transcoder_port, "vxgenabled": vxgenabled, "auth": auth}

wedebe avatar Jan 12 '21 16:01 wedebe

I was looking at plugins/controllers/models.py. The port is hardcoded into enigma2 (lib/dvb/streamserver.cpp) as 8001.

adoxa avatar Jan 13 '21 01:01 adoxa