Move the ActiveGate structs to separate package

[0sewa0]

K8S-11245

Description

ActiveGate and related structs have been moved to their own package, as a first step (and proof of concept) to make the api packages more organized.

Look at commits for more details:

1. Extract common structs to common package
2. Remove dead code
3. Update CRD generation
4. Move the ActiveGate structs to separate package

Still TODO: Add tests for pkg/api/v1beta3/dynakube/activegate/props.go

How can this be tested?

No change in actual behaviour, mainly look at the changes in the usage of the activegate package and common package, ask questions if something is hard to understand.

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.26923% with 99 lines in your changes missing coverage. Please review.

Project coverage is 64.45%. Comparing base (2b7405f) to head (9d4a0f3). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...beta3/dynakube/activegate/zz_generated.deepcopy.go	21.12%	48 Missing and 8 partials :warning:
pkg/api/shared/image/zz_generated.deepcopy.go	0.00%	8 Missing :warning:
pkg/api/shared/proxy/zz_generated.deepcopy.go	0.00%	8 Missing :warning:
pkg/api/shared/value/zz_generated.deepcopy.go	0.00%	8 Missing :warning:
.../api/shared/communication/zz_generated.deepcopy.go	33.33%	6 Missing :warning:
pkg/api/v1beta3/dynakube/activegate/props.go	92.98%	2 Missing and 2 partials :warning:
pkg/api/v1beta3/dynakube/zz_generated.deepcopy.go	78.57%	3 Missing :warning:
pkg/api/v1beta3/dynakube/activegate/status.go	50.00%	2 Missing :warning:
cmd/troubleshoot/image.go	0.00%	1 Missing :warning:
.../api/v1alpha2/edgeconnect/zz_generated.deepcopy.go	0.00%	1 Missing :warning:
... and 2 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3895      +/-   ##
==========================================
+ Coverage   64.39%   64.45%   +0.05%     
==========================================
  Files         372      380       +8     
  Lines       20550    20526      -24     
==========================================
- Hits        13234    13230       -4     
+ Misses       6034     6013      -21     
- Partials     1282     1283       +1     

Flag	Coverage Δ
unittests	64.45% <68.26%> (+0.05%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[andriisoldatenko]

there are still some uncommitted changes in your branch:

➜  dynatrace-operator git:(refactor/api-package-v2) ✗ gs
On branch refactor/api-package-v2
Your branch is up to date with 'origin/refactor/api-package-v2'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   config/crd/bases/dynatrace.com_edgeconnects.yaml
        modified:   config/helm/chart/default/templates/Common/crd/dynatrace-operator-crd.yaml