Don't update k8s-settings object, if already present

[0sewa0]

Description

K8S-11513

If we update the k8s settings object that already exists, for some reason causes data gaps.

We should avoid updating it, as it was done before v1.3

The diff looks a bit confusing:

• I just moved the settings.TotalCount > 0 check(and related calls) , before the r.dtc.CreateOrUpdateKubernetesSetting(... call

How can this be tested?

There was a unit-test that was supposed to test for this.

• I fixed it, now it fails with the old logic

Otherwise you have to make it update, and see gaps in the collected data

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (05257c8) to head (8bb9a49). Report is 1 commits behind head on release-1.3.

Files with missing lines	Patch %	Lines
...g/controllers/dynakube/apimonitoring/reconciler.go	55.55%	3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##           release-1.3    #3886   +/-   ##
============================================
  Coverage        64.34%   64.34%           
============================================
  Files              353      353           
  Lines            19012    19012           
============================================
  Hits             12233    12233           
  Misses            5526     5526           
  Partials          1253     1253           

Flag	Coverage Δ
unittests	64.34% <55.55%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.