dynatrace-operator icon indicating copy to clipboard operation
dynatrace-operator copied to clipboard

Remove deprecation filter on OneAgent pod's proxy argument and env var

Open albertogdd opened this issue 1 year ago • 1 comments

Description

K8S-11311

When removing a proxy from our DynaKube, we need to add --set-proxy="" argument to OneAgent pods to trigger its proxy configuration deletion. This PR removes a logic that only adds this arg and env var on specific OneAgent versions and set these always.

How can this be tested?

  • Deploy DynaKube with proxy
  • Check that proxy is configured in OA pod (run on pod shell cat /mnt/volume_storage_mount/var_log/os/ruxitagent_* | grep Proxy)
  • Remove proxy from DynaKube
  • Check that --set-proxy="" is set in OA manifest
  • Check that proxy configuration is gone (run on pod shell cat /mnt/volume_storage_mount/var_log/os/ruxitagent_* | grep Proxy)

NOTE: While testing it was noticed that proxy config may sometimes not be getting properly set in pod and not shown in the shell command even when should be configured (maybe based on tenants or different setups?)

albertogdd avatar Oct 03 '24 09:10 albertogdd

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.38%. Comparing base (9b8545b) to head (07e8f93).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3880      +/-   ##
==========================================
+ Coverage   64.37%   64.38%   +0.01%     
==========================================
  Files         372      372              
  Lines       20542    20515      -27     
==========================================
- Hits        13223    13208      -15     
+ Misses       6036     6030       -6     
+ Partials     1283     1277       -6     
Flag Coverage Δ
unittests 64.38% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 03 '24 09:10 codecov-commenter