Dylan Vann
Dylan Vann
Sounds great, thank you!
It's not used anywhere in the code. Actually mediasoup-demo-app-media-query-detector in the HTML file is not used anywhere either. This could be another PR. I'll split this.
I'm converting a large codebase to TypeScript and am attempting to use @janicduplessis fork. I changed the tests around a bit since they weren't working when I checked out the...
I believe it's specifically comments preceding/following nodes that are replaced by the converter. The same problem can occur when writing codemods, as I'm experiencing right now trying to write a...
I like that it's more generalized, I fixed that issue on my fork, but it only works one level deep, which isn't very good.
I came up with a less drastic way of improving the tests, so I can keep track of changes more easily. This will allow you to use AVA's `-u` or...
Yeah async is going to be in an issue. The challenge of this package is avoiding a flash of an incorrect theme, so it needs to be synchronous, or else...
Maybe I could make the prefix configurable. If you want a workaround this will work: ```tsx let modePrevious; window.__pdm__.mode.subscribe((mode) => { const htmlElement = document.documentElement; htmlElement.classList.remove(modePrevious); htmlElement.classList.add(mode); modePrevious = mode;...
I would just change the comment to something like: ```js // TODO: Add test for x functionality. ``` I think even `TODO: test.` passes. More like a sentence, less like...
Yeah I think the current answer is probably a no. If you want to make a case for adding support a new issue can be opened. Animated gifs are supported,...