DrahtBot comments

Results 2618 comments of


                                            DrahtBot

refactor: Return `util::Result` from WalletLoader methods

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ### Conflicts Reviewers, this pull request conflicts with the following ones: * [#25722](https://github.com/bitcoin/bitcoin/pull/25722) (refactor: Use util::Result...

[Draft / POC] Silent Payments

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ### Reviews See [the guideline](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#code-review) for information on the review process. | Type | Reviewers |...

[Draft / POC] Silent Payments

🐙 This pull request conflicts with the target branch and [needs rebase](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes). Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

build: add test_bitcoin.exe to win installer, don't install entire docs/ dir

### Guix builds | File | commit a6fc293c0a1f27ba1e573bfa16fd76d5f58988b2(master) | commit 7a7e37fb91ae81d39361b195c05117b502e3046b(master and this pull) | |--|--|--| | SHA256SUMS.part | [`ee1df5c52df292d7...`](https://drahtbot.space/guix/bitcoin/bitcoin/a6fc293c0a1f27ba1e573bfa16fd76d5f58988b2/SHA256SUMS.part) | [`bf990d822b946c5b...`](https://drahtbot.space/guix/bitcoin/bitcoin/7a7e37fb91ae81d39361b195c05117b502e3046b/SHA256SUMS.part) | | *-aarch64-linux-gnu-debug.tar.gz | [`3c5094ea45e3eabc...`](https://drahtbot.space/guix/bitcoin/bitcoin/a6fc293c0a1f27ba1e573bfa16fd76d5f58988b2/bitcoin-a6fc293c0a1f-aarch64-linux-gnu-debug.tar.gz) | [`09453f3fc041362a...`](https://drahtbot.space/guix/bitcoin/bitcoin/7a7e37fb91ae81d39361b195c05117b502e3046b/bitcoin-7a7e37fb91ae-aarch64-linux-gnu-debug.tar.gz) |...

util, config: error on startup if `conf` or `reindex` are set in config file

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ### Conflicts No conflicts as of last run.

rpc: add ability to export/import descriptor files in `listdescriptors` and `importdescriptors`

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ### Conflicts Reviewers, this pull request conflicts with the following ones: * [#26156](https://github.com/bitcoin/bitcoin/pull/26156) (test: check that...

build: Add -fvisibility=hidden flag for macOS host

build: Add CMake-based build system

scripted-diff: test: rename `MAX_{ANCESTORS,DESCENDANTS}` to `DEFAULT_{ANCESTOR,DESCENDANT}_LIMIT`

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ### Conflicts Reviewers, this pull request conflicts with the following ones: * [#25792](https://github.com/bitcoin/bitcoin/pull/25792) (test: add tests...