ember-router-scroll icon indicating copy to clipboard operation
ember-router-scroll copied to clipboard

Published 20 hours ago • verified publisher icon DockYard

Any reason scrollElement needs an ID?

Open samselikoff opened this issue 8 years ago • 5 comments

Could we change scrollElement to accept any CSS selector, like a class?

samselikoff avatar Oct 21 '17 15:10 samselikoff

Yes, absolutely @samselikoff. Not sure that is the way it is. PR's welcomed.

briangonzalez avatar Oct 21 '17 15:10 briangonzalez

It seems this issue was fixed.

yowainwright avatar Jun 15 '18 00:06 yowainwright

@yowainwright I believe this is still an issue: https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/services/router-scroll.js#L54

I'd like scrollElement to be able to be any css selector (not targetElement)

Mind reopening?

samselikoff avatar Nov 07 '18 21:11 samselikoff

@samselikoff do you have time to submit a PR with this update? Thank you.

Thanks for articulating the issue as well.

yowainwright avatar Nov 08 '18 04:11 yowainwright

I don't at the moment but let's leave this open for now, may be able to carve out some time soon-ish

samselikoff avatar Nov 08 '18 12:11 samselikoff