ember-router-scroll
ember-router-scroll copied to clipboard
[Update] add more tests
Add more tests
For this issue more testing will be implemented.
Reasons 🤔
- easier code review
- tests need to be added for future features like:
- post-merge publishing and changelog updates,
- automerge
Steps 📊
The checklist key items will be in separate PRs for readability. Versioning for these PRs will try to best support the community.
Key Items ✅
- [ ] Add unit tests specific to location/router-scroll.js
- [ ] Add unit tests specific to services/router-scroll.js
- [ ] Add acceptance tests
- [ ] Spike: Other test opportunities?
@rwwagner90 will manage open issues. I am closing this pr. This issue will not be done.
Adding more tests is probably a good idea. We can keep this open.