Sebastian Stauch

Not needed any more

Hello @dims I've deployed the controller into our IPv6 Kubernetes clusters and tested both modes (`--dualstack=true`,`--dualstack=false`) with the following controllers enabled (`--controllers=cloud-node,cloud-node-lifecycle,nodeipam,service,route`). The code is similar to https://github.com/kubernetes/cloud-provider-gcp/blob/master/cmd/cloud-controller-manager/nodeipamcontroller.go . What...

> @DockToFuture also there are some unit tests there in that other repo you pointed to, some of it may be ported over here as well? https://cs.k8s.io/?q=func%20Test&i=nope&files=.*nodeipam.*_test%5C.go&excludeFiles=&repos=kubernetes/cloud-provider-gcp I've added all...

> It should be possible to use this as a drop-in replacement to the ipam controller we implemented in kOps. I expect kOps would still handle assigning the actual prefixes...

> @DockToFuture so what i was thinking was if we were to enhance one of the existing harness(es) to enable this control, for example `make test-e2e` uses `kops` to setup...

I've update the PR with an e2e test. A valid domain needs to be provided to run the e2e tests successfully. It's required to get the kops cluster up and...

PR is now ready for review! :)

Any more feedback @M00nF1sh?

Hello @dims, I've rebased the PR.

@dims I've rebased the PR. Can you take a look?