ng-promise-button icon indicating copy to clipboard operation
ng-promise-button copied to clipboard

Don't specify any default templates, use the default button text

Open niemyjski opened this issue 10 years ago • 1 comments

I think that by default you shouldn't mess with the button content. If anything provide an easy way to specify a loading icon (with position).

niemyjski avatar Mar 20 '15 17:03 niemyjski

Thank you for comment. My philosophy is to keep default to match majority of use cases and then, if needed, to provide ways to override it.

I think intention of current default is to have simple way to make ready to use button without repeating myself. Since you're the first one who wants to change it, I'm keeping it as it now.

You are of course free to make patch that provide override, I'll be happy to merge it. Dne 20. 3. 2015 17:11 "Blake Niemyjski" [email protected] napsal(a):

I think that by default you shouldn't mess with the button content. If anything provide an easy way to specify a loading icon (with position).

— Reply to this email directly or view it on GitHub https://github.com/DocX/ng-promise-button/issues/2.

DocX avatar Mar 30 '15 08:03 DocX