Sovryn-smart-contracts

Sovryn-smart-contracts copied to clipboard

the tests are slow and can be improved dramatically suggestions: 1. snapshot repeating scenarios https://ethereum-waffle.readthedocs.io/en/latest/fixtures.html 2. use mocks https://ethereum-waffle.readthedocs.io/en/latest/mock-contract.html added a task 3. beforeEach -> before move repetitive beforeEach with...

ghost

_callOptionalReturn function doesn't have a check to verify if it is a Contract Account or Externally Owned Account. It was on hold due to Contract Size issue. The changes are...

smbsp

functionSelectors.js

3

Script in python or js to extend functionSignatures.sh, add params as needed, compute selectors (four bytes of the Keccak-256 or SHA-3 hash of the signature of the function)

computerphysicslab

UPD: moved to #325 description we need to be able to rollback loan token logic fast in case of emergency implementation we need to store the previous logic contract per...

tjcloa

Prevent lending and withdrawal within the same tx/block #199 (medium): To protect from the lending fees manipulation using flash loan we need to prevent lending and withdrawing from the pools...

computerphysicslab

add: deposit collateral - allow users to hold in the currency of the loan

1

the users' collateral for a margin trade is currently always held in the collateral currency we need to allow collateral to be held in the currency of the loan e.g....

tjcloa

1. add swapsFeePercent on the protocol 2. add function setSwapsFeePercent() to SwapsExternal module 3. add deployment script which sets swapsFeePercent percent - set it 0.05% for testing 4. use swapsFeePercent...

tjcloa

Integration test scripts after redeployments

1

https://discord.com/channels/729675474665603133/746409782226976858/863033607333085214 need to wrap the functions in an intergation test add results verification

tjcloa

Add admin role in protocol settings Add pauser role in priceFeeds Add deployment script for transferring ownership to governance Prettier and linting contract

cwsnt

https://github.com/DistributedCollective/Sovryn-smart-contracts/pull/311 as discussed primarily with @smbsp e.g. in _setTarget(this.swapExternal.selector, target); this.swapExternal.selector is replaced for this.swapExternal.selector^this.xor.selector (which should be a constant - ) in all modules that will lead to calling...

tjcloa