ExchangeSharp icon indicating copy to clipboard operation
ExchangeSharp copied to clipboard

IsQuantityReverted, IsPriceReverted flags

Open spiritedbytes opened this issue 4 years ago • 2 comments
trafficstars

Hello guys,

I am wondering if it makes sense to introduce the following two flags:

  • IsPriceReverted
  • IsQuantityReverted

Because we have a global format BASE-QUOTE and the price format is 1 base = X quote. But what if the format is reversed on an exchange? Also, the quantity format can be reversed too (in the library we specify the amounts in quote currency vs base one).

The IsPriceReverted will revert the price by dividing it by 1. The IsQuantityReverted will revert the quantity by dividing it by price (Ask/Bid/Limit).

But I already see the MarketSymbolIsReverted flag, however, I am not sure if it's a complete substitution to the two flags I mentioned above. Do you know if it makes sense to develop these two flags?

spiritedbytes avatar Jan 20 '21 20:01 spiritedbytes

Not a bad idea. @jjxtra, what do you think?

vslee avatar Jan 25 '21 03:01 vslee

Sure sounds good!

jjxtra avatar Jan 25 '21 03:01 jjxtra