dice icon indicating copy to clipboard operation
dice copied to clipboard

added support for DUMP command

Open TheRanomial opened this issue 1 year ago • 7 comments

TheRanomial avatar Sep 20 '24 13:09 TheRanomial

Hi @TheRanomial , I have doubts regarding the implementation, just for my understanding purposes. I tried running the commands in redis and it was a different output. I understand that we might be using some other algorithm to dump the key. However when I read more about it online, it seems like DUMP and RESTORE go hand in hand. I feel that along with DUMP command, we should be implementing RESTORE such that the behavior can be validated completely. What are your thoughts on this?

apoorvyadav1111 avatar Sep 20 '24 18:09 apoorvyadav1111

I am having problems in running the restore command. I have made a commit which is failing test cases as restore is being timed out . @apoorvyadav1111. Added implementation for restore but it is not working i guess.

TheRanomial avatar Sep 21 '24 19:09 TheRanomial

Hey @TheRanomial , I tried some changes on my local using your branch and I was able to run following commands. image I share suggestions in the review for what changes I made. Since dump supports all data types, we need to handle all the types including set, hmap and json. We can discuss further on discord if you would prefer. Thanks

apoorvyadav1111 avatar Sep 21 '24 20:09 apoorvyadav1111

@apoorvyadav1111 Thanks a lot for your suggestions. I made the changes you requested and the tests are working fine. Also added the TTL functionality. Open to new changes if any.

TheRanomial avatar Sep 21 '24 21:09 TheRanomial

@lucifercr07 kindly review it.

TheRanomial avatar Sep 22 '24 10:09 TheRanomial

@TheRanomial apologies for delay will review by tomorrow, meanwhile can you resolve conflicts?

lucifercr07 avatar Sep 23 '24 20:09 lucifercr07

@lucifercr07 solved the conflicts.

TheRanomial avatar Sep 24 '24 18:09 TheRanomial