added support for DUMP command
Hi @TheRanomial , I have doubts regarding the implementation, just for my understanding purposes. I tried running the commands in redis and it was a different output. I understand that we might be using some other algorithm to dump the key. However when I read more about it online, it seems like DUMP and RESTORE go hand in hand. I feel that along with DUMP command, we should be implementing RESTORE such that the behavior can be validated completely. What are your thoughts on this?
I am having problems in running the restore command. I have made a commit which is failing test cases as restore is being timed out . @apoorvyadav1111. Added implementation for restore but it is not working i guess.
Hey @TheRanomial , I tried some changes on my local using your branch and I was able to run following commands.
I share suggestions in the review for what changes I made. Since dump supports all data types, we need to handle all the types including set, hmap and json. We can discuss further on discord if you would prefer. Thanks
@apoorvyadav1111 Thanks a lot for your suggestions. I made the changes you requested and the tests are working fine. Also added the TTL functionality. Open to new changes if any.
@lucifercr07 kindly review it.
@TheRanomial apologies for delay will review by tomorrow, meanwhile can you resolve conflicts?
@lucifercr07 solved the conflicts.