dice icon indicating copy to clipboard operation
dice copied to clipboard

Add integration test for ABORT command

Open JyotinderSingh opened this issue 1 year ago • 8 comments

  • Add an integration test for the abort command.
  • The test should ensure that the server shuts down in time once the abort command is received.
  • Restart the server to ensure restarts are also successful.
  • Ensure that the server port is released when the server is shut down.

JyotinderSingh avatar Sep 01 '24 09:09 JyotinderSingh

Please can you assign this to me?

tdadadavid avatar Sep 01 '24 09:09 tdadadavid

I would love to have a swing at this one :)

@JyotinderSingh

chettriyuvraj avatar Sep 01 '24 11:09 chettriyuvraj

Please can you assign this to me?

Assigned.

JyotinderSingh avatar Sep 01 '24 16:09 JyotinderSingh

@JyotinderSingh i tried to implement it and also a PR for it. Can you have a look? https://github.com/DiceDB/dice/pull/442

TheRanomial avatar Sep 03 '24 06:09 TheRanomial

@JyotinderSingh I worked on the abort test command #451

tdadadavid avatar Sep 04 '24 10:09 tdadadavid

Hello @tdadadavid,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Sep 09 '24 09:09 arpitbbhayani

My apologies for the silence.

Due to the new changes (refactoring), I have to rebase the PR I made. Thanks

tdadadavid avatar Sep 09 '24 18:09 tdadadavid

@JyotinderSingh I reworked the abort test command #531

tdadadavid avatar Sep 11 '24 00:09 tdadadavid