dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `EXPIREAT`

Open arpitbbhayani opened this issue 1 year ago • 7 comments

Add support for the EXPIREAT command in DiceDB similar to the EXPIREAT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Aug 09 '24 04:08 arpitbbhayani

I want to complete this task

GoGoGoFast avatar Aug 09 '24 07:08 GoGoGoFast

I want to complete this task

Assigned

JyotinderSingh avatar Aug 09 '24 07:08 JyotinderSingh

I have a question, that is, after setting the expiration time, do I need to scan it regularly, or do I have to judge it when it is available? I found this problem when I was testing just now.

GoGoGoFast avatar Aug 10 '24 11:08 GoGoGoFast

I have a question, that is, after setting the expiration time, do I need to scan it regularly, or do I have to judge it when it is available? I found this problem when I was testing just now.

We automatically perform expiry both as a part of the main loop, as well as during GET operations.

JyotinderSingh avatar Aug 10 '24 19:08 JyotinderSingh

Okok, that's good, that means that this function is perfect at present, right? Then I'll test it again

GoGoGoFast avatar Aug 11 '24 06:08 GoGoGoFast

hi @arpitbbhayani @JyotinderSingh I would like to work on this issue. @JyotinderSingh would you please assign this task to me.

ashwaniYDV avatar Aug 17 '24 23:08 ashwaniYDV

hi @arpitbbhayani @JyotinderSingh I would like to work on this issue.

@JyotinderSingh would you please assign this task to me.

Assigned

JyotinderSingh avatar Aug 18 '24 07:08 JyotinderSingh