dice
dice copied to clipboard
DiceDB
Add support for command `DUMP`
Add support for the DUMP command in DiceDB similar to the DUMP command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.
Created a design document to be sure about the implementation. Can you please go through can provide comments? Thanks.
Quick Queries:
- Should we include TTL in the response?
- Should we include DiceDB version in the response?
cc: @arpitbbhayani @JyotinderSingh @soumya-codes @yashs360
PS: Please request access for editing/commenting on the doc since I do not have your emails.
Hey @ashwaniYDV I am currently working on it. Waiting on maintainers to provide comments. I will remind them again.
Hey @ashwaniYDV I am currently working on it. Waiting on maintainers to provide comments. I will remind them again.
Apologies, this skipped my mind. @soumya-codes could you also take a look?
@ashwaniYDV Hey. You can continue on this. Can't work this week, therefore un-assigning myself.
@soumya-codes @JyotinderSingh please assign it to me, would like to work on this.
Hi @soumya-codes / @JyotinderSingh any work happening on this ? Would be great to work on this if possible
@lucifercr07 I have tried to implement this command. Can you assign this to me?
Hello @TheRanomial,
There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.
#633 referenced this issue and has been successfully merged and closed.