dice icon indicating copy to clipboard operation
dice copied to clipboard

Published 20 hours ago • verified publisher icon DiceDB

feat:add persist cmd

Open codeErrorSleep opened this issue 1 year ago • 1 comments
trafficstars

feat:add persist command issue #258

codeErrorSleep avatar Aug 07 '24 05:08 codeErrorSleep

The implementation looks good to me, can you also add tests for the command

srivastava-yash avatar Aug 07 '24 21:08 srivastava-yash

@srivastava-yash Thank you for the reminder. I have added unit tests and resubmitted the code. Could you please review it? P.S.: The current implementation is not based on interfaces, so methods like get cannot be mocked.

codeErrorSleep avatar Aug 08 '24 15:08 codeErrorSleep

LGTM. @codeErrorSleep, I am not a maintainer of this project. Tagging @JyotinderSingh to confirm and approve

srivastava-yash avatar Aug 08 '24 15:08 srivastava-yash

@codeErrorSleep please rebase the PR on the latest master to resolve conflicts. Will review once done.

JyotinderSingh avatar Aug 08 '24 15:08 JyotinderSingh

@JyotinderSingh I have merged the master branch.

codeErrorSleep avatar Aug 08 '24 15:08 codeErrorSleep