dice
dice copied to clipboard
Integration Tests for H* Commands
We already have some integration tests written for commands like HSET, HGET, HGETALL, and HGETALL.WATCH.
This issue is all about making the integration tests more stringent for the same commands. Command implementations can be found in files
/internal/cmd/cmd_hget.go/internal/cmd/cmd_hset.go/internal/cmd/cmd_hgetall.go/internal/cmd/cmd_hgetall_watch.go
Tests can be found in the file
/tests/commands/ironhawk/hget_test.go/tests/commands/ironhawk/hset_test.go/tests/commands/ironhawk/hgetall_test.go/tests/commands/ironhawk/hgetall_watch_test.go
We need help with updating of integration tests as per the business logic implemented in the commands.
Setup Instructions
- setup DiceDB server locally from the source - instructions
- setup DiceDB Go SDK locally from the source - instructions
- setup DiceDB CLI locally from the source - instructions
- refer to the
Pointing to local checked-outdicedb-gosection inREADME`.
Start the DiceDB server
$ go run main.go --log-level debug
Follow the contribution guidelines
These are general guidelines to follow before you submit a patch. Please mark them as done once you complete them
- [ ] please go through the CONTRIBUTING guide
- [ ] follow LOGGING best practices
- [ ] follow Golang best practices
- [ ] run
make linton your local copy of the codebase
Hey @arpitbbhayani , will update the tests. Please assign!
Thanks @iamskp11 assigned!
Hi @iamskp11, are you still working on this issue?
Hey @helios2003 , please take this up. Won't be able to prioritise this this week.
Thank you @iamskp11. Could you please assign me this issue @arpitbbhayani?
@arpitbbhayani @JyotinderSingh @lucifercr07 Can you review it?
Hey @arpitbbhayani @JyotinderSingh @lucifercr07 ! Is this issue still open? I can reopen #1681 to fix this issue.