dice icon indicating copy to clipboard operation
dice copied to clipboard

Integration Tests for H* Commands

Open arpitbbhayani opened this issue 7 months ago • 7 comments
trafficstars

We already have some integration tests written for commands like HSET, HGET, HGETALL, and HGETALL.WATCH.

This issue is all about making the integration tests more stringent for the same commands. Command implementations can be found in files

  • /internal/cmd/cmd_hget.go
  • /internal/cmd/cmd_hset.go
  • /internal/cmd/cmd_hgetall.go
  • /internal/cmd/cmd_hgetall_watch.go

Tests can be found in the file

  • /tests/commands/ironhawk/hget_test.go
  • /tests/commands/ironhawk/hset_test.go
  • /tests/commands/ironhawk/hgetall_test.go
  • /tests/commands/ironhawk/hgetall_watch_test.go

We need help with updating of integration tests as per the business logic implemented in the commands.

Setup Instructions

  1. setup DiceDB server locally from the source - instructions
  2. setup DiceDB Go SDK locally from the source - instructions
  3. setup DiceDB CLI locally from the source - instructions
  4. refer to the Pointing to local checked-out dicedb-gosection inREADME`.

Start the DiceDB server

$ go run main.go --log-level debug

Follow the contribution guidelines

These are general guidelines to follow before you submit a patch. Please mark them as done once you complete them

arpitbbhayani avatar Mar 23 '25 18:03 arpitbbhayani

Hey @arpitbbhayani , will update the tests. Please assign!

iamskp11 avatar Mar 23 '25 18:03 iamskp11

Thanks @iamskp11 assigned!

arpitbbhayani avatar Mar 23 '25 18:03 arpitbbhayani

Hi @iamskp11, are you still working on this issue?

helios2003 avatar Apr 03 '25 11:04 helios2003

Hey @helios2003 , please take this up. Won't be able to prioritise this this week.

iamskp11 avatar Apr 03 '25 16:04 iamskp11

Thank you @iamskp11. Could you please assign me this issue @arpitbbhayani?

helios2003 avatar Apr 03 '25 17:04 helios2003

@arpitbbhayani @JyotinderSingh @lucifercr07 Can you review it?

manishrw avatar Apr 07 '25 05:04 manishrw

Hey @arpitbbhayani @JyotinderSingh @lucifercr07 ! Is this issue still open? I can reopen #1681 to fix this issue.

manishrw avatar Jun 09 '25 06:06 manishrw