dice icon indicating copy to clipboard operation
dice copied to clipboard

Fix/wal fatal on failure

Open suhailroushan13 opened this issue 8 months ago • 5 comments

fix: exit on WAL initialization failure to prevent data corruption

🔍 Overview

  • Added a fatal log and immediate shutdown if WAL initialization fails.
  • Prevents running in a corrupted state where data persistence is uncertain.
  • Improves debugging by making WAL failures explicit.
  • Reduces silent failures that could lead to data loss or unexpected crashes.

🛠️ Impact

✅ Ensures data durability by stopping execution when WAL fails.
✅ Helps debug issues faster by logging a clear fatal error.
✅ Prevents unintended behaviors due to partial WAL initialization.

🔄 Before vs After

Before:

  • Logs an error but allows the server to continue running.
  • Could lead to unexpected failures when WAL is required.

After:

  • Immediately exits with a fatal error message.
  • Ensures the database does not start in an unsafe state.

suhailroushan13 avatar Mar 16 '25 15:03 suhailroushan13

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant

Please remove the Lincese Script changes from this PR.

arpitbbhayani avatar Mar 22 '25 11:03 arpitbbhayani

@suhailroushan13 any updates?

arpitbbhayani avatar Mar 23 '25 18:03 arpitbbhayani

Apologies for that — I’ve removed the license script changes from this PR as requested.
Let me know if there’s anything else I should update!

suhailroushan13 avatar Mar 23 '25 20:03 suhailroushan13

@suhailroushan13 because of last merge of your changes in license file, there are conflicts here. You will need to pull the latest changes and update this PR. This is gtg, I will merge it as soon as you resolve the conflicts. THanks.

arpitbbhayani avatar Mar 26 '25 17:03 arpitbbhayani