dice icon indicating copy to clipboard operation
dice copied to clipboard

Optimize license header script and improve efficiency

Open suhailroushan13 opened this issue 8 months ago • 4 comments
trafficstars

Improvements in This Version

Handles package declaration properly
Preserves file permissions
Avoids unnecessary grep calls in the loop
Uses mapfile for efficiency (reduces subshells)
More optimized find command usage

suhailroushan13 avatar Mar 16 '25 15:03 suhailroushan13

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant

@suhailroushan13 Please accept the CLA agreement before I can merge. Also, can you attach the proof that this script when run on the codebase works fine.

arpitbbhayani avatar Mar 22 '25 11:03 arpitbbhayani

@suhailroushan13 any updates?

arpitbbhayani avatar Mar 23 '25 18:03 arpitbbhayani

Hey! First of all, sorry for the late reply.

I've run the script on the codebase, and it works as expected. The header has been successfully added to the relevant files, and the script also displays which files were updated. Please find the proof attached below:

image

Let me know if there's anything else needed from my side!

suhailroushan13 avatar Mar 23 '25 20:03 suhailroushan13

Thanks for the patch. Merged.

arpitbbhayani avatar Mar 26 '25 17:03 arpitbbhayani