dice icon indicating copy to clipboard operation
dice copied to clipboard

Published 20 hours ago • verified publisher icon DiceDB

HGETALL WATCH Support

Open Nachiket18 opened this issue 10 months ago • 4 comments
trafficstars

This PR adds support for the HGETALL.WATCH command, allowing clients to watch whenever the data inside the respective hash set changes.

HGETALL Command doc - https://redis.io/docs/latest/commands/hgetall/

Nachiket18 avatar Jan 06 '25 20:01 Nachiket18

@JyotinderSingh - @asaurabh12 and I have made changes to watch_manager.go, constants.go and cmd_meta.go. The doubt we have is about eval.go because the file structure has changed from when the ZRANGE WATCH PR was designed. Should the changes be done in store_eval in this new design?

Nachiket18 avatar Jan 11 '25 22:01 Nachiket18

@Nachiket18 let us know when this PR can be reviewed. Right now it is in draft state.

arpitbbhayani avatar Jan 23 '25 05:01 arpitbbhayani

@Nachiket18 let us know when this PR can be reviewed. Right now it is in draft state.

Thanks @arpitbbhayani - We have made some changes but have doubts about how to handle changes in eval.go as the code structure has changed since last PR to add ZRANGEWATCH was completed.

Nachiket18 avatar Jan 23 '25 16:01 Nachiket18

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant

we have already added this command in latest version of DiceDB. this PR is redundant, closing it. Really appreciate your patch!

arpitbbhayani avatar Apr 30 '25 02:04 arpitbbhayani