dice icon indicating copy to clipboard operation
dice copied to clipboard

Add support for command `GEORADIUS_RO`

Open arpitbbhayani opened this issue 1 year ago • 4 comments

Add support for the GEORADIUS_RO command in DiceDB similar to the GEORADIUS_RO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

arpitbbhayani avatar Nov 07 '24 15:11 arpitbbhayani

Hi, I'd like to take this up. Can you please assign this to me?

ankkyprasad avatar Nov 08 '24 14:11 ankkyprasad

Hi @ankkyprasad , Assigned. Thanks for contributing to DiceDB.

apoorvyadav1111 avatar Nov 09 '24 16:11 apoorvyadav1111

@ankkyprasad Are you still working on this ? If not @apoorvyadav1111 Can you please assign me this ?

vpsinghg avatar Dec 02 '24 05:12 vpsinghg

Hi, @vpsinghg. GEORADIUS_RO is a sub issue of #1321, which I am working on. So, Can I pick up this issue? Thanks

c-harish avatar Dec 02 '24 16:12 c-harish