dice icon indicating copy to clipboard operation
dice copied to clipboard

feat: dsql grammar and parser implementation

Open manojpramesh opened this issue 1 year ago • 4 comments

Ref: https://github.com/DiceDB/dice/issues/1228

This is a draft implementation of dsql grammar using antlr4. Improves the performance of query executer and avoids retrofitted error handling.

This code can be further cleaned, but would wait for the initial review considering it is a total rewrite of how DSQL is handled

manojpramesh avatar Nov 01 '24 14:11 manojpramesh

This is a super interesting PR, I'll go through it soon.

JyotinderSingh avatar Nov 05 '24 19:11 JyotinderSingh

@JyotinderSingh Fixed the build issues and rebased with latest changes. Will wait for the initial review (no hurry) before adding more features considering it is a rewrite and the team may have different views.

manojpramesh avatar Nov 25 '24 10:11 manojpramesh

Thanks for providing this update Manoj. We have removed support for the Q.WATCH feature for now in the new multi-threaded server due to less community interest around it. Let's revisit this PR once we add back the support for this feature. I will keep this PR open.

JyotinderSingh avatar Nov 26 '24 04:11 JyotinderSingh

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant

this is obsolete now. Closing the PR to keep things clean. Thanks for working on the patch.

arpitbbhayani avatar Apr 29 '25 18:04 arpitbbhayani