dice icon indicating copy to clipboard operation
dice copied to clipboard

Feat/cuckoo filter

Open ashutoshdhande opened this issue 1 year ago • 3 comments

Overview
This PR implements the core functionalities for the Cuckoo Filter commands CF.RESERVE, CF.ADD, and CF.EXISTS.

Current Status

  • The main functionalities are working as expected.
  • There are several TODOs remaining that I plan to address in future updates, including:
    • Proper error handling
    • Code refactoring for improved readability and maintainability

This PR is a work in progress and serves as a draft. Additional enhancements will be made before finalizing.

ashutoshdhande avatar Oct 27 '24 17:10 ashutoshdhande

@ashutoshdhande are you still working on this PR? Are you blocked by anything?

JyotinderSingh avatar Nov 17 '24 06:11 JyotinderSingh

@ashutoshdhande are you still working on this PR? Are you blocked by anything?

@JyotinderSingh Yup, there’s some progress, but expect a slight delay. Support has now been added for the following commands:
CF.EXISTS, CF.MEXISTS
CF.ADD, CF.ADDNX
CF.INSERT, CF.INSERTNX
CF.DEL
CF.RESERVE

One challenge I faced was ensuring consistent output. I've been manually verifying this by comparing results between one Dice DB session and one Redis session. Can you suggest a more efficient way to handle this?

Next on the hit list is examining how the filter behaves as it approaches capacity specifically, how it grows and whether it still functions correctly when items are displaced from their primary and secondary indices.

ashutoshdhande avatar Nov 18 '24 00:11 ashutoshdhande

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 20 '25 11:03 CLAassistant