dice icon indicating copy to clipboard operation
dice copied to clipboard

Published 20 hours ago • verified publisher icon DiceDB

config: use pflag to let viper override cmd flags

Open codeasashu opened this issue 1 year ago • 1 comments

This fixes #1094

codeasashu avatar Oct 14 '24 19:10 codeasashu

@JyotinderSingh Take a look at this one too, its quite small one to be merged

codeasashu avatar Oct 20 '24 17:10 codeasashu

I'm not sure if we should be refactoring viper related changes as new config is in work. We can merge this PR for now but most likely be redone in few weeks. @JyotinderSingh/@vinitparekh17 thoughts?

lucifercr07 avatar Oct 27 '24 12:10 lucifercr07

@lucifercr07 Since we agreed to eliminate most of these flags and simplify our implementation to be primarily config file-based, except for a few sub-commands like -help and -version, merging this PR may not make sense at this point. However, until we roll out those discussed changes, you may proceed with merging this PR to acknowledge the author’s efforts.

vinitparekh17 avatar Oct 27 '24 12:10 vinitparekh17

@vinitparekh17 is this PR still relevant based on the new changes?

JyotinderSingh avatar Nov 08 '24 16:11 JyotinderSingh

@vinitparekh17 is this PR still relevant based on the new changes?

No it is not.

vinitparekh17 avatar Nov 08 '24 16:11 vinitparekh17