dice icon indicating copy to clipboard operation
dice copied to clipboard

Enable multithreaded Config not respecting toml

Open codeasashu opened this issue 1 year ago • 3 comments

I have following dice.toml config:

dice.toml
Version = '0.0.4'
InstanceID = ''

[AsyncServer]
Addr = '0.0.0.0'
Port = 7379
KeepAlive = 300
Timeout = 300
MaxConn = 0

[HTTP]
Enabled = true
Port = 8082

[WebSocket]
Enabled = true
Port = 8379
MaxWriteResponseRetries = 3
WriteResponseTimeout = 10000000000

[Performance]
WatchChanBufSize = 20000
ShardCronFrequency = 1000000000
MultiplexerPollTimeout = 100000000
MaxClients = 20000
EnableMultiThreading = true
StoreMapInitSize = 1024000
AdhocReqChanBufSize = 20

[Memory]
MaxMemory = 0
EvictionPolicy = 'allkeys-lfu'
EvictionRatio = 0.9
KeysLimit = 200000000
LFULogFactor = 10

[Persistence]
AOFFile = './dice-master.aof'
PersistenceEnabled = true
WriteAOFOnCleanup = false

[Logging]
LogLevel = 'debug'
PrettyPrintLogs = true

[Auth]
UserName = 'dice'
Password = ''

[Network]
IOBufferLength = 512
IOBufferLengthMAX = 51200

and I am starting the server as: go run main.go -c dice.toml.

Expected behaviour

2024/10/14 23:05:33 INFO configurations loaded successfully.
11:05PM DBG The DiceDB server has started in multi-threaded mode. number of cores=8
11:05PM INF RESP Server successfully bound Host=0.0.0.0 Port=7379
11:05PM INF DiceDB ready to accept connections on port resp-port=7379
11:05PM INF Websocket Server running port=8379

Actual behaviour

2024/10/14 23:12:23 INFO configurations loaded successfully.
11:12PM DBG The DiceDB server has started in single-threaded mode.
11:12PM INF DiceDB server is running in a single-threaded mode port=7379 version=0.0.4
11:12PM WRN DiceDB is running without authentication. Consider setting a password.
11:12PM INF HTTP Server running addr=:8082
11:12PM INF Websocket Server running port=8379

The EnableMultiThreading = true isn't having any effect on the dice startup

codeasashu avatar Oct 14 '24 18:10 codeasashu

@kaushal-003 I am working on this

codeasashu avatar Oct 14 '24 19:10 codeasashu

Hello @codeasashu,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

arpitbbhayani avatar Oct 24 '24 13:10 arpitbbhayani

Hey @arpitbbhayani

As you can see in PR comment, Its been pending for a review. Similarly, for my other PR. There has been no review (even after pinging multiple times, here as well as on discord).

Every now and then, it becomes a challenge for me to keep rebasing things, especially the ones affecting main files. I am more than eager to contribute actively in the project, however, reviews are getting slowers, hence the inactivity

I'll rebase again today. Let me know if there is anything else I can do to catalyse the process.

codeasashu avatar Oct 24 '24 18:10 codeasashu

Closing as config have been migrated

apoorvyadav1111 avatar Nov 26 '24 23:11 apoorvyadav1111