dice
dice copied to clipboard
#632: Feature: KeepAlive and Timeout Support mechanism
Issue: #632
Summary: Added timeouts and keep alive mechanism for workers.
Changes: Added client and connection in worker struct Added functions related to keep alive and timeouts in workers.go
@Dev79844 we already have the timeout capability added to the connection instance itself. Please check here. https://github.com/DiceDB/dice/blob/master/internal/clientio/iohandler/netconn/netconn.go#L100
Can we figure out similar way to add keepalive?
Hey @soumya-codes As far as I understand the design, since each worker manages a client connection, the keep alive should be kept around a worker. Connection timeout is handled by the connection itself so I think keep alive should be managed by the worker itself. Would like to know your thoughts about this?
Hey @lucifercr07 @soumya-codes @apoorvyadav1111 I have added a basic code for bencmarking start method but I am not sure if it is correct. It would be great if you can provide feedback.
this is obsolete now. Closing the PR to keep things clean. Thanks for working on the patch.