IronRDP icon indicating copy to clipboard operation
IronRDP copied to clipboard

refactor(ironrdp-web): fix `indexing_slicing` clippy lint warnings

Open RRRadicalEdward opened this issue 3 months ago • 4 comments

This lint

Checks for usage of indexing or slicing that may panic at runtime.

This one is quite pedantic and changes the way we write the code, but on the other hand, it makes the code more panic-resistant. Fixed the lint warnings only for ironrdp-web to see early feedback on it. If we agree on adding it, I will add this lint for each crate separately, because there are too many warnings to do in 1 PR: image

RRRadicalEdward avatar Sep 21 '25 14:09 RRRadicalEdward

Coverage Report :robot: :gear:

Past: Total lines: 30217 Covered lines: 18800 (62.22%)

New: Total lines: 30217 Covered lines: 18800 (62.22%)

Diff: +0.00%

[this comment will be updated automatically]

github-actions[bot] avatar Sep 21 '25 14:09 github-actions[bot]

@CBenoit Does it look good? Should we proceed with adding this lint?

RRRadicalEdward avatar Oct 03 '25 08:10 RRRadicalEdward

I want to double check a little bit more before merging this.

CBenoit avatar Oct 08 '25 11:10 CBenoit

I’m putting back this PR on my TODO review list.

CBenoit avatar Nov 06 '25 10:11 CBenoit