IronRDP icon indicating copy to clipboard operation
IronRDP copied to clipboard

feat(connector):Add ironrdp-vmconnector crate, integrated into existing ironrdp-client and ironrdp async

Open irvingoujAtDevolution opened this issue 5 months ago • 5 comments

Hello @CBenoit , I added dynamically dispatched trait for hyperv connector and normal connectors. The main drive is to avoid copy and paste in previous version. I did it this is way is also to reuse existing code as much as possible, instead of copy each and every method and add a _vmconnect suffix. This might not be the best solution, let me know your thoughts.

irvingoujAtDevolution avatar Jun 26 '25 15:06 irvingoujAtDevolution

@irvingoujAtDevolution I don’t remember very well. What is different from the previous version?

CBenoit avatar Jul 01 '25 12:07 CBenoit

@CBenoit The first version's main problem was that we modified on ClientConnector itself, which causes the state management less intuitive. The second version's problem was that, the logic for vmconnect are tied to io, and we uses a lot of boolean params and hardcoded logics to manually manipulate the connector's state, which is not FFI friendly.

irvingoujAtDevolution avatar Jul 01 '25 18:07 irvingoujAtDevolution

We were having CredSSP issues on enhanced mode, I intend to have that support in separate pull request.

irvingoujAtDevolution avatar Jul 04 '25 15:07 irvingoujAtDevolution

Coverage Report :robot: :gear:

Past: Total lines: 30220 Covered lines: 18820 (62.28%)

New: Total lines: 30541 Covered lines: 18831 (61.66%)

Diff: -0.62%

[this comment will be updated automatically]

github-actions[bot] avatar Jul 04 '25 17:07 github-actions[bot]

@irvingoujAtDevolution Can you rebase on top of master and address Copilot’s suggestions?

CBenoit avatar Nov 04 '25 13:11 CBenoit

@irvingoujAtDevolution Can you double check with cargo xtask ci?

CBenoit avatar Nov 18 '25 21:11 CBenoit

@irvingoujAtDevolution Can you resolve the conflicts with master?

CBenoit avatar Nov 20 '25 09:11 CBenoit