feat(connector):Add ironrdp-vmconnector crate, integrated into existing ironrdp-client and ironrdp async
Hello @CBenoit , I added dynamically dispatched trait for hyperv connector and normal connectors. The main drive is to avoid copy and paste in previous version. I did it this is way is also to reuse existing code as much as possible, instead of copy each and every method and add a _vmconnect suffix. This might not be the best solution, let me know your thoughts.
@irvingoujAtDevolution I don’t remember very well. What is different from the previous version?
@CBenoit The first version's main problem was that we modified on ClientConnector itself, which causes the state management less intuitive. The second version's problem was that, the logic for vmconnect are tied to io, and we uses a lot of boolean params and hardcoded logics to manually manipulate the connector's state, which is not FFI friendly.
We were having CredSSP issues on enhanced mode, I intend to have that support in separate pull request.
Coverage Report :robot: :gear:
Past: Total lines: 30220 Covered lines: 18820 (62.28%)
New: Total lines: 30541 Covered lines: 18831 (61.66%)
Diff: -0.62%
[this comment will be updated automatically]
@irvingoujAtDevolution Can you rebase on top of master and address Copilot’s suggestions?
@irvingoujAtDevolution Can you double check with cargo xtask ci?
@irvingoujAtDevolution Can you resolve the conflicts with master?