KotlinBukkitAPI icon indicating copy to clipboard operation
KotlinBukkitAPI copied to clipboard

Published 20 hours ago • verified publisher icon DevSrSouza

Menu update

Open Hai-tun opened this issue 4 years ago • 6 comments

Upgrade menu module

Hai-tun avatar Dec 20 '20 09:12 Hai-tun

Hey @Hai-tun, this for the PR, but, you can explain the changes that this PR does?

DevSrSouza avatar Dec 20 '20 12:12 DevSrSouza

menu : Separate cancelOnClick into cancelOnTopClick(defalut = true) and cancelOnBottomClick(defalut = false) (The bottom inventory will be clickable and moveable)

top drag : Changed from canceling the event to returning the illegally dragged item back to the cursor

bottom inventory double click : Add anti illegal bottom inventory shift click

bottom inventory shift click : Add anti illegal bottom inventory shift click

Hai-tun avatar Dec 21 '20 12:12 Hai-tun

@DevSrSouza Add an executor priority fix

Hai-tun avatar Jan 08 '21 06:01 Hai-tun

@DevSrSouza Plz, review code and merge.

Hai-tun avatar Jan 08 '21 06:01 Hai-tun

i think it would be better if you kept the cancelOnClick parameter of the menu func, for reasons of backward compatibility.

devnatan avatar Jan 18 '21 23:01 devnatan

It seems to be able to improve compatibility by that way... but in fact, the signature of the method has changed due to the addition of parameters. So even if cancelOnClick is not modified, the bytecode still unable to be compatible.

Hai-tun avatar Jan 19 '21 15:01 Hai-tun