Added velocity support

[KikyoC]

Hello, I added velocity support and I tested it and it looks working. I checked that the /unban bug (because of not cached) is fixed.

[Hopefuls]

are the changes based off of the development branch?

[KikyoC]

Nope I don't think, you can see here that I'm up to date with leoko dev branch here: https://github.com/KikyoC/AdvancedBan/tree/master

[Bensonheimer992]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

[Hopefuls]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

is this related to this pull request? if no then that is known.

[KikyoC]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

[Bensonheimer992]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

[KikyoC]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I don't have this issue. i'm checking it

[KikyoC]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

[Bensonheimer992]

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

[Bensonheimer992]

can i still use the normal advancedban api or do i have to do something special for it to work with the velocity version ?

because im trying to use the PunishEvent and nothing happens (i checked that the event is registered)

[Bensonheimer992]

Hey every time i ban someone with the Velocity Version of AdvancedBan i have to restart the proxy to unban them if i don't restart the proxy i get the message that this player is not banned

Hello, check this one, I'm waiting they response to open a second pr (because I did something stupid): https://github.com/Swordfun-Server/AdvancedBan

this version does not work either it still says after banning this player is not banned

I missed something. Should now work (with new release)

?

[KikyoC]

Hello, I havent edited anything from the api.

[Bensonheimer992]

but the event does not get triggered

[Bensonheimer992]

Hello, I havent edited anything from the api.

and maybe change the server type from BungeeCord to Velocity

[DevLeoko]

Thanks for your effort to support velocity @KikyoC Are the changes from this PR tested and stable? Because you mentioned newer changes and a second PR above.

[KikyoC]

Hey everyone !

I'm sorry if I don't answered on time. I get to many things in my life so that's why I'm answering late.

As I said I did something better on https://github.com/Swordfun-Server/AdvancedBan but I meged everything in this repo. I just tried and everything looks good.

[nhanledev]

Hello, I just tested the Velocity support by building https://github.com/Swordfun-Server/AdvancedBan and run it on my server (velocity only)

• mute, tempmute: OK, player can not send message after being muted
• ban, tempban: OK, player is kicked and can not join the server after being banned

[Hopefuls]

Hello @KikyoC,

wanted to possibly check up on this pr as I will also be testing it on my own soon (thanks @nhanledev for already looking into it).

Though I am still unsure as to how the specific change on the caching resolves the issue with the bans not being correctly handled, do you have some insights into this?

Thank you!

[Bensonheimer992]

When does it get merged ?

[alfi0812]

When does it get merged ?

When the guy respons to the questions of @Hopefuls. Otherwise it will probably just be closed. He got asked multiple times to respond on Discord and here.

[Hopefuls]

Likely an abandoned pull request due to the lack of responses from the original Creator of the PR

[Bensonheimer992]

Likely an abandoned pull request due to the lack of responses from the original Creator of the PR

Its Not abondoned

[Bensonheimer992]

I was able to persuade the creator not to delete the fork after all and he said if there are advancedban updates he will continue to develop it

[KikyoC]

Hey, I'm sorry I didn't receive any notification from github about this PR. (Thanks @Bensonheimer992 for dming me on discord). I will take a look about @Hopefuls this evening because I'm at school rn (Paris TZ)

[KikyoC]

So here are the new updates. It should be fine. If you said something in here and I didn't answer after 24h, do not hesitate to DM me on Discord

[Hopefuls]

I might create a new branch to merge into, the development branch seems to have changes that we wanted to disregard for now.

I'll get back to you if Leoko is fine with that. I'll be testing this until then though

[Hopefuls]

Checklist (I'll update and request once ready):

• [ ] Bump to Version 2.4.0 (currently 2.3.0) or alternatively 3.0.0 due to this being a entire new major release

[Hopefuls]

Failed to unban a user that was banned in the following way:

• banned the player "0bg" while that player was offline, using /ban 0bg
• tried connecting, failed -> correct behaviour
• trying to use /unban 0bg, failed as stated "player is not banned" -> incorrect behaviour

Behaviour seems to occur when:

• player has been on the server after a restart (join and leave)
• player is not online

This can be fixed by restarting the server, which then allows unbanning the player.

Steps to reproduce:

• have second account join the server
• have second account leave the server
• attempt banning
• observe success
• attempt unbanning
• observe fail
• attempt to restart server
• attempt unbanning
• observe success
• have second account join the server
• can join

my guess is that there's an issue within saving cached punishments.

[KikyoC]

Hey, thank you for that report. I'll look it this evening

[Bensonheimer992]

btw. Server shows BungeeCord instead of Velocity