testcafe-browser-provider-browserstack icon indicating copy to clipboard operation
testcafe-browser-provider-browserstack copied to clipboard

fix #152 - modify browserstack config file path to work

Open patrickathompson opened this issue 1 year ago • 3 comments

This change will modify the provided config file path to match the relative path of the file needed by the plugin to resolve it correctly.

patrickathompson avatar Aug 05 '24 20:08 patrickathompson

needs a test for configuration file + environment variables

patrickathompson avatar Aug 05 '24 23:08 patrickathompson

I realized that the _getAdditionalCapabilities logic was calling both functions _getCapabilitiesFromEnvironment and _getCapabilitiesFromConfig regardless of which configuration was used. Individual functions need to be modified with this in mind. This also necessitates an additional test scenario where the mixed configuration is used.

patrickathompson avatar Aug 06 '24 00:08 patrickathompson

Hello @patrickathompson,

Thank you for your pull request. We will review it and merge it if everything looks good.

PavelMor25 avatar Aug 09 '24 07:08 PavelMor25

This pull request has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this pull request in the future. If it is still relevant or you have any additional information regarding it, please leave a comment and we will keep it open.

github-actions[bot] avatar Feb 25 '25 02:02 github-actions[bot]

We're closing this pull request after a prolonged period of inactivity. If it is still relevant, please ask for this pull request to be reopened. Thank you.

github-actions[bot] avatar Mar 07 '25 02:03 github-actions[bot]