devextreme-reactive icon indicating copy to clipboard operation
devextreme-reactive copied to clipboard

Swap momentjs for another date-io compatible library

Open adamcarr opened this issue 5 years ago • 4 comments
trafficstars

  • [x] I have searched this repository's issues and believe that this is not a duplicate.

I'm using ...

  • [ ] React Grid
  • [ ] React Chart
  • [x] React Scheduler

Description

We are looking to start using React Scheduler and it has a direct dependency on momentjs which we are trying to avoid due to performance and package bloat. Your dependency on momentjs seems to be via date-io which is an abstraction that may allow swapping out to other libraries. Is this something you currently support or are considering supporting in the future?

Environment

  • devextreme-reactive: 2.7.0
  • react: 16.13.1
  • browser: all
  • bootstrap: none
  • react-bootstrap: none
  • material-ui: none

adamcarr avatar Aug 06 '20 18:08 adamcarr

Hi @adamcarr,

We are using the moment.js library inside our core package for complex calculations. Unfortunately, it's not possible to change this library.

I assigned an enhancement tag to this issue and we will consider it in future planning.

Can I ask you about what scheduler component your team will prefer and why? This information will help us to become better.

MaximKudriavtsev avatar Aug 07 '20 07:08 MaximKudriavtsev

We are going to use the React Scheduler in @devexpress/dx-react-scheduler. We will likely use many of the plugins already available as well. We are building a meeting booking system across multiple user accounts and this control greatly simplifies the amount of work we need to do. The question about moment.js is around trying to optimize our package payload and up until now we have been able to avoid moment.js.

adamcarr avatar Aug 10 '20 07:08 adamcarr

Thank you for the clarification.

MaximKudriavtsev avatar Aug 11 '20 07:08 MaximKudriavtsev

Hi there,

since moment is now kind of deprecated, maybe this issue should be reconsidered. In my opinion Luxon should allow a smooth migration, but obviously only someone with a deep knowledge of the library can say.

FedeBev avatar Apr 30 '21 13:04 FedeBev