nix-installer icon indicating copy to clipboard operation
nix-installer copied to clipboard

Published 20 hours ago • verified publisher icon DeterminateSystems

Fix fish support on ostree

Open grahamc opened this issue 2 years ago • 3 comments
trafficstars

Description

Closes #707

Checklist
  • [x] Formatted with cargo fmt
  • [ ] Built with nix build
  • [ ] Ran flake checks with nix flake check
  • [ ] Added or updated relevant tests (leave unchecked if not applicable)
  • [ ] Added or updated relevant documentation (leave unchecked if not applicable)
  • [ ] Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

grahamc avatar Nov 08 '23 19:11 grahamc

Unfortunately this doesn't work: the plan says to create the directory, then the planning phase detects the directory doesn't exist (yet) and decides to not install it. Hrm.

grahamc avatar Nov 09 '23 02:11 grahamc

I believe that is because of

https://github.com/DeterminateSystems/nix-installer/blob/a026cc2224ec2cc7aa5d53c542521eb0cea1ad37/src/action/common/configure_shell_profile.rs#L83-L86

Perhaps that should happen at execute time.

Hoverbear avatar Nov 09 '23 16:11 Hoverbear

Marking this as a draft based on this previous comment: https://github.com/DeterminateSystems/nix-installer/pull/711#issuecomment-1803062901.

cole-h avatar Dec 05 '23 19:12 cole-h