DIM icon indicating copy to clipboard operation
DIM copied to clipboard

Include +1 resilience from Solstice Vest (Rekindled) ornament in armor stats

Open Revadike opened this issue 2 years ago • 7 comments

Proposed change

You already mention it gives a +1. Please also include it in your stat calculations. 🙏 image

How does this fit into your workflow?

It's just more accurate

Revadike avatar Apr 18 '23 10:04 Revadike

How should Loadout Optimizer deal with this?

robojumper avatar Apr 18 '23 12:04 robojumper

How should Loadout Optimizer deal with this?

I don't care much about that personally. I mostly care about it being reflected in the saved build stats/totals. Later, if you want, you could add a toggle for loadout optimizer to add constant +1 to resil.

Revadike avatar Apr 18 '23 12:04 Revadike

I'm not sure what I'm looking at here. Does the ornament somehow give +1 Resilience?

bhollis avatar May 11 '23 19:05 bhollis

I'm not sure what I'm looking at here. Does the ornament somehow give +1 Resilience?

It does

Revadike avatar May 11 '23 19:05 Revadike

Sounds like a bug on Bungie's side, ornaments really shouldn't grant stats. But besides that, I'd expect that DIM treats it like any other plug and automatically includes its stats in any calculations. Do you have screenshots showing that it doesn't?

bhollis avatar May 11 '23 19:05 bhollis

Loadout stats generally do not look at the fashion part of a loadout (modsByBucket) right now, and additionally there's some validation that ensures only subclass plugs and known-valid armor mod PlugCategoryHashes affect stats.

robojumper avatar May 11 '23 19:05 robojumper

Sounds like a bug on Bungie's side, ornaments really shouldn't grant stats. But besides that, I'd expect that DIM treats it like any other plug and automatically includes its stats in any calculations. Do you have screenshots showing that it doesn't?

It's a bug, but a longstanding one that I don't think will get fixed anytime soon. Besides, DIM already reports on it, just now with their calculations.

Revadike avatar May 11 '23 19:05 Revadike