kglab icon indicating copy to clipboard operation
kglab copied to clipboard

Improve installation

Open Mec-iS opened this issue 3 years ago • 7 comments

I'm submitting a

  • [X] feature request.

Current Behaviour:

Current installation is possible only with pip

Expected Behaviour:

It may be good for accessibility to provide installation via python-poetry and suggest Anaconda in the README for people that prefer conda environments

cc: @ceteri

Mec-iS avatar Sep 07 '22 10:09 Mec-iS

Outstanding, using poetry would be a nice improvement for kglab !

We have support for conda (especially for the RAPIDS integration, e.g., cuGraph, etc.) and there's a brief mention in the README for that.

ceteri avatar Sep 16 '22 22:09 ceteri

@ceteri @Mec-iS are you wanting to move the KGLab package build to poetry?

ghost avatar Sep 17 '22 15:09 ghost

we would like to provide different alternatives for installation, one of which can be poetry. ideally the requirements definition should be same between requirements.txt and pyproject.toml

Mec-iS avatar Sep 17 '22 17:09 Mec-iS

Something less 2008-ish :)

It gets interesting to support a wider range of alternatives for installation, given that the RAPIDS parts can only be installed with conda which is specifically configured through the NVIDIA release selector https://rapids.ai/start.html#get-rapids

That said, we don't want to become a conda-only package.

ceteri avatar Sep 17 '22 18:09 ceteri

I'll do a bit of poking around and come back with some ideas for pipenv and poetry

ghost avatar Sep 17 '22 18:09 ghost

I will update the readme with install instructions for poetry and pipenv to install as a pypi package to use in a project. I will also make updates to install the dev/test tutorial requirements with poetry and pipenv. I'll create a pyproject.toml for poetry and a Pipfile for pipenv.

Created https://github.com/DerwenAI/kglab/issues/275 to split changes

ghost avatar Sep 22 '22 02:09 ghost

This is the related PR for this issue https://github.com/DerwenAI/kglab/pull/299

jake-aft avatar Dec 03 '22 22:12 jake-aft