Add expirationTime to the PushSubscription in the web-push package

[apokryfos]

The JSON strigified PushSubscription object may have a expirationTime property. This is documented in the toJSON method at https://developer.mozilla.org/en-US/docs/Web/API/PushSubscription/toJSON

Please fill in this template.

• [x] Use a meaningful title for the pull request. Include the name of the package modified.
• [x] Test the change in your own code. (Compile and run.)
• [x] Add or edit tests to reflect the change.
• [x] Follow the advice from the readme.
• [x] Avoid common mistakes.
• [x] Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• [x] Provide a URL to documentation or source code which provides context for the suggested changes: PushSubscription.toJSON
• [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json. -- I believe the library already is accounting for this, but was omitted in the type declarations here

[typescript-bot]

@apokryfos Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

• web-push — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 70676,
  "author": "apokryfos",
  "headCommitOid": "fde6ff840d2b5511d92f166150349e5c8d401567",
  "mergeBaseOid": "8bc945982972001f6afb4ce17c897ec91d35628f",
  "lastPushDate": "2024-09-25T16:47:01.000Z",
  "lastActivityDate": "2024-10-22T07:43:59.000Z",
  "mergeOfferDate": "2024-10-21T22:25:17.000Z",
  "mergeRequestDate": "2024-10-22T07:43:59.000Z",
  "mergeRequestUser": "apokryfos",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "web-push",
      "kind": "edit",
      "files": [
        {
          "path": "types/web-push/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/web-push/web-push-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "paullessing"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-10-21T22:24:39.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2374615785,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @paullessing — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

Re-ping @paullessing:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @apokryfos.

(Ping @paullessing.)

[typescript-bot]

@apokryfos: Everything looks good here. I am ready to merge this PR (at fde6ff8) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! :heart:

(@paullessing: you can do this too.)

[apokryfos]

Ready to merge