DefinitelyTyped
DefinitelyTyped copied to clipboard
build(@rdfjs/serializer-rdfjs): is actually ESM
@tpluscode Thank you for submitting this PR!
This is a live comment which I will keep updated.
1 package in this PR
Code Reviews
Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.
You can test the changes of this PR in the Playground.
Status
- ✅ No merge conflicts
- ✅ Continuous integration tests have passed
- ✅ Most recent commit is approved by type definition owners, DT maintainers or others
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.
Diagnostic Information: What the bot saw about this PR
{
"type": "info",
"now": "-",
"pr_number": 69601,
"author": "tpluscode",
"headCommitOid": "57e87d4a4e012abb25a0bb1a6e2b6a9c20427fa9",
"mergeBaseOid": "cb74c940100800002511f412841ecd6cdc4c4e65",
"lastPushDate": "2024-05-14T11:27:26.000Z",
"lastActivityDate": "2024-05-30T08:53:56.000Z",
"mergeOfferDate": "2024-05-30T08:26:52.000Z",
"mergeRequestDate": "2024-05-30T08:53:56.000Z",
"mergeRequestUser": "tpluscode",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "attw.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": true
},
{
"name": "rdfjs__serializer-rdfjs",
"kind": "edit",
"files": [
{
"path": "types/rdfjs__serializer-rdfjs/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"tpluscode",
"BenjaminHofstetter"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Anonymous4078",
"date": "2024-05-30T08:26:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2109959996,
"ciResult": "pass"
}
🔔 @BenjaminHofstetter — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.
@tpluscode Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!
Re-ping @BenjaminHofstetter:
This PR has been out for over a week, yet I haven't seen any reviews.
Could someone please give it some attention? Thanks!
@tpluscode: Everything looks good here. I am ready to merge this PR (at 57e87d4) on your behalf whenever you think it's ready.
If you'd like that to happen, please post a comment saying:
Ready to merge
and I'll merge this PR almost instantly. Thanks for helping out! :heart:
(@BenjaminHofstetter: you can do this too.)
Ready to merge