Kubernetes Ingress class deprecated in helm chart deployment

[borovskimateusz]

Bug description Helm chart use depraced kubernetes.io/ingress.class it's problem with cloud deployment of nginx ingress with that class we should add separated file in templates https://github.com/DefectDojo/django-DefectDojo/tree/master/helm/defectdojo/templates with spec.ingressClassname

Steps to reproduce Steps to reproduce the behavior:

1. Go to https://github.com/DefectDojo/django-DefectDojo/blob/master/helm/defectdojo/templates/django-ingress.yaml

Expected behavior When upgrade helm deployment like. helm upgrade --install defectdojo ./ --values ./custom-values.yaml --namespace securecodebox-system

we got warning: W0321 14:44:35.026276 38208 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

Deployment method (select with an X)

• [ ] Docker Compose
• [X] Kubernetes
• [ ] GoDojo

Screenshots

Additional context (optional) Add any other context about the problem here.

[mtesauro]

@dsever FYI

[valentijnscholten]

wdyt @kiblik

[kiblik]

I see that support for spec.ingressClassname was added in #5772 However, I see that since #3687, there is support for GKE, which uses the annotation kubernetes.io/ingress.class. Unfortunately, I currently do not have access to a GKE environment where I would be able to test the removal/adjustment of this field. If there is someone who can prepare PR and properly test it, I see no problem in accepting it. However, I'm not able to do it by myself at the moment.

[valentijnscholten]

@borovskimateusz are you able to make and test a PR that incorporates this change?

[kiblik]

Ok, I found the official source. Deprecation is not connected to GKE but to whole k8s. So it is safe to remove it.

[kiblik]

Fixed in #12986, will be released as part of v2.50.0