django-DefectDojo icon indicating copy to clipboard operation
django-DefectDojo copied to clipboard

Trufflehog v3+ JSON format not supported

Open Ayrx opened this issue 3 years ago • 1 comments

DefectDojo currently has two parsers for "Trufflehog":

The first parser works for the old JSON format for Trufflehog. This output format can be generated by the latest version of Trufflehog with the --json-legacy flag.

According to #3935, the second parser is meant to support truffleHog3, a fork / enhanced version of the initial Trufflehog.

Version 3.0+ of the original Trufflehog introduces a new JSON format that is currently unsupported by DefectDojo. This output format can be generated by the latest version of Trufflehog with the --json flag. Support for this format is essential because it is the only output format supported by Trufflehog for non-git data sources.

The choice of the names for the second parser is also unfortunate because it leads to confusion over whether it is meant for Trufflehog v3+ or truffleHog3.

I would be happy to contribute support for the new JSON format but would like to open up discussions over cleaning up the naming confusion for the different parsers first.

Ayrx avatar Sep 12 '22 07:09 Ayrx

@damiencarol Thoughts?

mtesauro avatar Sep 12 '22 14:09 mtesauro

what a mess. My understanding is it's 2 different projects that share the same name. How unfortunate. I think @Maffooch made an excellent job in #6937 to solve this issue by adding accurate descriptions for both parsers.

damiencarol avatar Oct 06 '22 20:10 damiencarol

@damiencarol Requesting to reopen this because #6937 doesn't add full support for the v3+ JSON. The latest version of Trufflehog adds support for collectors like the filesystem one that does not contain the git commit information that the current code expects is there.

Ayrx avatar Oct 07 '22 00:10 Ayrx

@Ayrx mmm. better to open a new issue. I hope the format doesn't change too much. I can take a look if you open a new issue.

damiencarol avatar Oct 07 '22 06:10 damiencarol